allow client to remove created tasks with PID 0#7787
Merged
estesp merged 1 commit intocontainerd:mainfrom Dec 9, 2022
Merged
Conversation
Fixes containerd#7357 If a container is restored from a checkpoint that has a configuration error, the task for the restored container is created, but fails to start and is left in the state CREATED with a PID of 0. Before this change, the only way to remove this task was to find the PID of the shim monitoring the task and kill that process. Now, ctr t rm <task> will work on tasks that result in the CREATED state with PID 0. Signed-off-by: Gavin Inglis <[email protected]>
|
Hi @ginglis13. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
AkihiroSuda
approved these changes
Dec 9, 2022
Member
|
/ok-to-test |
dmcgowan
added
cherry-picked/1.6.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7357
If a container is restored from a checkpoint that has a configuration error, the task for the restored container is created, but fails to start and is left in the state CREATED with a PID of 0.
In the original issue, the induced error comes from call to
task.Start:The main task created from a restored container will always be PID 0 before the task is explicitly started
containerd/cmd/ctr/commands/containers/restore.go
Line 107 in e1abaeb
I had originally intended to make a change on the go-runc side to prevent PID 0 tasks from even being created, but given that restored tasks are assigned a PID at
task.Start, that would have been a breaking change.If the task fails to start in this case, the task will be left in the CREATED state with PID 0. Before this change, the only way to remove this task was to find the PID of the shim monitoring the task and kill that process. Now,
ctr t rm <task>will work on tasks that result in the CREATED state with PID 0.Signed-off-by: Gavin Inglis [email protected]