There is no way to disable debug endpoint on Darwin#7775
Merged
mxpv merged 1 commit intocontainerd:mainfrom Dec 8, 2022
Merged
There is no way to disable debug endpoint on Darwin#7775mxpv merged 1 commit intocontainerd:mainfrom
mxpv merged 1 commit intocontainerd:mainfrom
Conversation
AkihiroSuda
approved these changes
Dec 8, 2022
dcantah
approved these changes
Dec 8, 2022
samuelkarp
approved these changes
Dec 8, 2022
Member
|
need to rebase to fix the CI |
Signed-off-by: Maksym Pavlenko <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Linux and Windows we use
platformAgnosticDefaultConfig, which has debug endpoint disabled by default.On Darwin, we specify
defaults.DefaultDebugAddress.So when using
address = ""in the config file, it just defaults todefaults.DefaultDebugAddress.This PR just uses
platformAgnosticDefaultConfigfor all platforms, so debug endpoint can be enabled as needed from config.Signed-off-by: Maksym Pavlenko [email protected]