fix: check for tmpfs when evaluating if userxattr is needed#7772
fix: check for tmpfs when evaluating if userxattr is needed#7772dmcgowan merged 1 commit intocontainerd:mainfrom
Conversation
|
Hi @mathis-m. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
mathis-m
force-pushed
the
fix/userxattr_on_tmpfs
branch
from
a717171 to
3e145a0
Compare
| log.L.WithError(err).Warnf("Could not retrieve statfs for %v", d) | ||
| return false |
There was a problem hiding this comment.
I want to return this error, but this is coming from @AkihiroSuda's comment.
@AkihiroSuda - The errors on https://man7.org/linux/man-pages/man2/statfs.2.html#ERRORS seem pretty rare. Other operations would fail if statfs fails. So is it really make sense to log and essentially ignore the error?
There was a problem hiding this comment.
Maybe not pretty rare on fuse
mathis-m
force-pushed
the
fix/userxattr_on_tmpfs
branch
from
3e145a0 to
5fd98ce
Compare
mathis-m
force-pushed
the
fix/userxattr_on_tmpfs
branch
2 times, most recently
from
463823a to
b76d30f
Compare
|
sorry for the force pushes tried to fix the |
Signed-off-by: mathis-m <[email protected]>
mathis-m
force-pushed
the
fix/userxattr_on_tmpfs
branch
from
b76d30f to
2eabcf7
Compare
AkihiroSuda
added
cherry-picked/1.6.x
5 participants
Fixes #7770
It uses statfs to check if the dir provided to NeedsUserXAttr function is on a tempfs.
For detail information see #7770