support fetching containerd from non public GCS buckets#7771
support fetching containerd from non public GCS buckets#7771estesp merged 2 commits intocontainerd:mainfrom
Conversation
- add support to fetch and download containerd tarball from GCS buckets that require authentication. GCS_BUCKET_TOKEN should have read access to the bucket from which artifacts are to be fetched. The token is expected to be present in the instance metadata of the VM, similar to other node environment variables Signed-off-by: Akhil Mohan <[email protected]>
|
Hi @akhilerm. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @estesp @samuelkarp |
| source "${CONTAINERD_HOME}/${CONTAINERD_ENV_METADATA}" | ||
| fi | ||
|
|
||
| # GCS_BUCKET_TOKEN_METADATA is the metadata key for the GCS bucket token |
There was a problem hiding this comment.
Is it okay to keep set -o xtrace on the top of this file? I'm fine removing that to be honest.
There was a problem hiding this comment.
I dont want to remove tracing from the file, as it greatly helps with debugging the tests. Will figure out a way so that the token is not directly printed into the logs.
There was a problem hiding this comment.
@kzys Have updated the changes so that tracing is disabled when dealing with tokens
Signed-off-by: Akhil Mohan <[email protected]>
|
/cc @kzys |
5 participants
GCS_BUCKET_TOKEN should have read access to the bucket from which artifacts are to be fetched. The token is expected to be present in the instance metadata of the VM, similar to other node environment variables
Signed-off-by: Akhil Mohan [email protected]
To use this in tests from kubernetes, a new node env can be added as follows here.
<your_gcs_bucket_token>can be fetched from a secret or from an env.