Fix process_vm_* syscall names in seccomp#7755
Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom Dec 5, 2022
Merged
Conversation
Signed-off-by: Craig Ingram <[email protected]>
|
Hi @cji. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Member
|
/ok-to-test |
samuelkarp
approved these changes
Dec 3, 2022
cpuguy83
approved these changes
Dec 3, 2022
AkihiroSuda
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7693 we added two ptrace related syscalls for kernels >= 4.8, however I believe the syscall names had a minor typo.
Both the man page and the docker seccomp default that was being compared show the syscalls are named:
process_vm_readvprocess_vm_writev(This is also the syscall name we use later in this file when
CAP_SYS_PTRACEis checked here)It may be worth trying to confirm (using a toy program that uses the
process_vm_readysyscall) that this now provides the expected behavior if someone can help with that.Signed-off-by: Craig Ingram [email protected]