Skip to content

Unwrap proto errors in streaming client#7753

Merged
estesp merged 1 commit intocontainerd:mainfrom
dmcgowan:transfer-wrap-stream-proxy-errors
Dec 5, 2022
Merged

Unwrap proto errors in streaming client#7753
estesp merged 1 commit intocontainerd:mainfrom
dmcgowan:transfer-wrap-stream-proxy-errors

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan commented Dec 2, 2022

Allows clients to properly detect context cancellation

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Dec 2, 2022

/ok-to-test

@dmcgowan dmcgowan marked this pull request as draft December 2, 2022 19:45
@dmcgowan dmcgowan force-pushed the transfer-wrap-stream-proxy-errors branch 3 times, most recently from 682e0dd to c05bdc1 Compare December 2, 2022 23:45
Allows clients to properly detect context cancellation

Signed-off-by: Derek McGowan <[email protected]>
@dmcgowan dmcgowan force-pushed the transfer-wrap-stream-proxy-errors branch from c05bdc1 to 8a25fa5 Compare December 3, 2022 06:31
@dmcgowan dmcgowan marked this pull request as ready for review December 3, 2022 07:05
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 9f44e6c into containerd:main Dec 5, 2022
@dmcgowan dmcgowan deleted the transfer-wrap-stream-proxy-errors branch December 14, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants