Skip to content

use MaxConcurrentDownloads instead of MaxConcurrentUploadedLayers#7736

Merged
mxpv merged 1 commit intocontainerd:mainfrom
jellor:pull-image
Nov 29, 2022
Merged

use MaxConcurrentDownloads instead of MaxConcurrentUploadedLayers#7736
mxpv merged 1 commit intocontainerd:mainfrom
jellor:pull-image

Conversation

@jellor
Copy link
Copy Markdown
Contributor

@jellor jellor commented Nov 29, 2022

use MaxConcurrentDownloads instead of MaxConcurrentUploadedLayers to limit max concurrent layer downloads while pulling an image.

Signed-off-by: guodong [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Nov 29, 2022

Hi @jellor. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mxpv mxpv merged commit aff2cbe into containerd:main Nov 29, 2022
@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Jan 24, 2023

@samuelkarp I see you marked for cherry-picking for 1.6.x, but it looks like this code is not in that branch (at least not in this form); was there an issue in 1.6 as well, or should the cherry-pick label be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@mxpv mxpv mxpv approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jellor @k8s-ci-robot @thaJeztah @dmcgowan @mxpv @dcantah @samuelkarp