Skip to content

fuzzing: improve archive fuzzer#7718

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
AdamKorcz:fuzz1234
Dec 12, 2022
Merged

fuzzing: improve archive fuzzer#7718
dmcgowan merged 1 commit intocontainerd:mainfrom
AdamKorcz:fuzz1234

Conversation

@AdamKorcz
Copy link
Copy Markdown
Contributor

@AdamKorcz AdamKorcz commented Nov 24, 2022

Currently the fuzzer does not check all the files in the tar archive which it should. This pr fixes that.

Signed-off-by: AdamKorcz [email protected]

@AdamKorcz AdamKorcz marked this pull request as ready for review November 24, 2022 18:48
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Nov 24, 2022

Hi @AdamKorcz. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

samuelkarp
samuelkarp reviewed Nov 25, 2022
View reviewed changes
Comment thread contrib/fuzz/archive_fuzzer.go Outdated
samuelkarp
samuelkarp approved these changes Nov 25, 2022
View reviewed changes
Comment thread contrib/fuzz/archive_fuzzer.go Outdated
dcantah
dcantah reviewed Nov 28, 2022
View reviewed changes
Comment thread contrib/fuzz/archive_fuzzer.go Outdated
dcantah
dcantah approved these changes Nov 28, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit

@dmcgowan dmcgowan self-assigned this Nov 30, 2022
@samuelkarp
Copy link
Copy Markdown
Member

samuelkarp commented Dec 2, 2022

Code LGTM, but do you mind squashing the three commits into one?

@AdamKorcz
Copy link
Copy Markdown
Contributor Author

AdamKorcz commented Dec 3, 2022

Code LGTM, but do you mind squashing the three commits into one?

Done!

kzys
kzys approved these changes Dec 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan do you want to take a look?

@dmcgowan dmcgowan merged commit 1823757 into containerd:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

@dmcgowan dmcgowan

Labels

needs-ok-to-test

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AdamKorcz @k8s-ci-robot @samuelkarp @kzys @dmcgowan @dcantah