Hi @kiashok. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Thanks, but please sign the commit for DCO
https://github.com/apps/dco

(run git commit -a -s --amend, and make sure that the Signed-off-by: NAME <EMAIL> line with your real name is included in the commit message)

Could you pls add the same fix for sbserver ?

Can we add a test case to cover this as well?

This will also need backport to 1.6 branch, right? Is the same problem present in 1.5 branch?

/ok-to-test

Can we add a test case to cover this as well?

This will also need backport to 1.6 branch, right? Is the same problem present in 1.5 branch?

Added the test. Yes this needs to be backported to 1.6. 1.5 branch does not have these changes so we could skip backporting there

The linux integration test that is failing seems to be flaky and and is not related to any changes made in this PR. The changes in this PR is mostly on the windows side and I also see another PR that is failing at the same location (at log_hook.go at line 40) - https://github.com/containerd/containerd/actions/runs/3526988813/jobs/5915601489 .