Resolve warnings in Windows GitHub Actions periodic workflows#7706
Conversation
|
Hi @austinvazquez. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Maintainers curious if I could get some help verifying these changes. Workflow runs on forks fail without proper GCP and Azure setup. cc: @estesp |
|
@aznashwan @gabriel-samfira Could you take a look? |
Just ran the Process Isolation workflow and Hyper-V workflow workflows on my fork and what's here LGTM! Unfortunately because the Hyper-V workflow got merged after #7516 and #7581, there's still some warnings in it:
@austinvazquez could you please handle these warnings here too or would you rather I make a separate PR for them? |
Great to hear @aznashwan! I'll take a peek at your Hyper-V results. I can get them in this PR and start the process for cherry-picking into release. Thanks for the help. |
austinvazquez
force-pushed
the
resolve-windows-workflow-warnings
branch
from
c40eb49 to
5dc8258
Compare
Upgrade actions/github-script from v3 to v6 to resolve Node.js 12 and `set-output` command warnings. Upgrade google-github-actions/upload-cloud-storage from v0.8.0 to v0.10.4 to resolve `set-output` command warnings. Upgrade actions/checkout from v2 to v3 to resolve Node.js 12 warnings. Remove references to `set-output` command from workflow. Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
resolve-windows-workflow-warnings
branch
from
5dc8258 to
8c035d3
Compare
6 participants
Upgrade actions/github-script from v3 to v6 to resolve Node.js 12 and
set-outputcommand warnings.Upgrade google-github-actions/upload-cloud-storage from v0.8.0 to v0.10.4 to resolve
set-outputcommand warnings.Upgrade actions/checkout from v2 to v3 to resolve Node.js 12 warnings.
Remove references to
set-outputcommand from workflow.https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Latest Windows Periodic Run: https://github.com/containerd/containerd/actions/runs/3510720613
Latest Windows Hyper-V Periodic Run: https://github.com/containerd/containerd/actions/runs/3510698554
Related issue: containerd/project#95
Signed-off-by: Austin Vazquez [email protected]