Skip to content

Missed out platform interface when reused the conn for Client.#7699

Merged
estesp merged 1 commit intocontainerd:mainfrom
yanggangtony:client-with-conn
Nov 21, 2022
Merged

Missed out platform interface when reused the conn for Client.#7699
estesp merged 1 commit intocontainerd:mainfrom
yanggangtony:client-with-conn

Conversation

@yanggangtony
Copy link
Copy Markdown
Contributor

@yanggangtony yanggangtony commented Nov 19, 2022

Signed-off-by: yanggang [email protected]

I think the platform will be processd later .
Like the image.go or.. others..

func NewImage(client *Client, i images.Image) Image {
	return &image{
		client:   client,
		i:        i,
		platform: client.platform,
	}
}

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Nov 19, 2022

Hi @yanggangtony. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

estesp
estesp approved these changes Nov 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit de73676 into containerd:main Nov 21, 2022
@yanggangtony yanggangtony deleted the client-with-conn branch November 25, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@fuweid fuweid fuweid approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yanggangtony @k8s-ci-robot @estesp @fuweid