Skip to content

cri: add pod uid annotation#7697

Merged
estesp merged 1 commit intocontainerd:mainfrom
inspektor-gadget:qasim/add-sandbox-uid-annotation
Nov 21, 2022
Merged

cri: add pod uid annotation#7697
estesp merged 1 commit intocontainerd:mainfrom
inspektor-gadget:qasim/add-sandbox-uid-annotation

Conversation

@mqasimsarfraz
Copy link
Copy Markdown
Contributor

@mqasimsarfraz mqasimsarfraz commented Nov 18, 2022 •
edited
Loading

Containerd already has annotations for pod name an pod namespace this PR introduces an annotation for pod uid. This will be helpful for projects like inspektor-gadget to simplify getting metadata about pods.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Nov 18, 2022

Hi @mqasimsarfraz. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mqasimsarfraz mqasimsarfraz force-pushed the qasim/add-sandbox-uid-annotation branch 2 times, most recently from 3b21c13 to 8cc3a5a Compare November 18, 2022 16:57
@mxpv
Copy link
Copy Markdown
Member

mxpv commented Nov 18, 2022 •
edited
Loading

Can you pls update sbserver too to keep them in sync while migrating.

mikebrow
mikebrow reviewed Nov 18, 2022
View reviewed changes
Comment thread pkg/cri/annotations/annotations.go Outdated
mikebrow
mikebrow reviewed Nov 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see nit comment to explain the difference between the two ids... if we had a place to list our annotations this information would be useful...

nod to @mxpv 's ask to pls merge into sandboxed as well

@mqasimsarfraz
cri: add pod uid annotation
0c4d32c 
Signed-off-by: Qasim Sarfraz <[email protected]>
@mqasimsarfraz mqasimsarfraz force-pushed the qasim/add-sandbox-uid-annotation branch from 8cc3a5a to 0c4d32c Compare November 19, 2022 00:12
@mqasimsarfraz
Copy link
Copy Markdown
Contributor Author

mqasimsarfraz commented Nov 19, 2022

see nit comment to explain the difference between the two ids... if we had a place to list our annotations this information would be useful...

+1

nod to @mxpv 's ask to pls merge into sandboxed as well

Great, thanks for the quick review and feedback, I updated the PR!

estesp
estesp approved these changes Nov 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 99acefa into containerd:main Nov 21, 2022
@mqasimsarfraz
Copy link
Copy Markdown
Contributor Author

mqasimsarfraz commented Nov 21, 2022

Thanks for the reviews and the merge. Given the patch is low risk and doesn't impact any current features should I go ahead and propose a backport for release/1.6 ?

@alban alban mentioned this pull request Nov 23, 2022
Merged
@mqasimsarfraz mqasimsarfraz mentioned this pull request Nov 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikebrow mikebrow mikebrow left review comments

@estesp estesp estesp approved these changes

@fuweid fuweid fuweid approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mqasimsarfraz @k8s-ci-robot @mxpv @estesp @mikebrow @fuweid