Hi @swagatbora90. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

@swagatbora90
Hi,Thanks for your work, I want to know is it mean the image registry can get the traceid when containerd pull image?

@swagatbora90 Hi,Thanks for your work, I want to know is it mean the image registry can get the traceid when containerd pull image?

Hi @liangyuanpeng, This PR instruments tracing specifically to the calls received by the CRI stream server from Kubelet or directly from API Server. This supports the exec, attach and port-forward operations. Also, to correlate the traces with the client request, the client will need to send the context containing the necessary tracing info as part of the http request headers. Otelhttp provides Transport to do just that.

Yes, it is possible for containerd to send traceid information as part of the http request to image registries. Currently, it is only creating a span on the client side but if needed, we can look into sending the trace information in the request as well. link

/cc @mxpv @kzys

Needs rebase to resolve merge conflicts

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 7 days unless new comments are made or the stale label is removed.

PR needs rebase.

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 7 days unless new comments are made or the stale label is removed.

This PR was closed because it has been stalled for 7 days with no activity.