Skip to content

Conversation

@sofat1989
Copy link

Signed-off-by: Fei Su [email protected]

can set up the network serially by CNI plugins

Indeed we have two CNI plugins which have independent CNI configuration files. For example

tnet.conf ztio.conf

We want to run these two plugins serially. because running CNI plugin in ztio.conf will depend on some configurations set by the CNI plugin in tnet.conf.

By default, containerd will run them parallelly. So it may fail randomly.

For CNI interface, there is a function SetupSerially reserved for setting up serially. So we want that there is a flag in the config file of containerd to control this.

The expected config in config.toml:

[plugins."io.containerd.grpc.v1.cri".cni]
      max_conf_num = 2
      setup_serially = true

@k8s-ci-robot
Copy link

Hi @sofat1989. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I agree with @fuweid's comment, so small bit of feedback)

@fuweid fuweid merged commit 8e78754 into containerd:main Nov 19, 2022
mxpv added a commit to mxpv/containerd that referenced this pull request Jan 17, 2023
Signed-off-by: Maksym Pavlenko <[email protected]>
mxpv added a commit to mxpv/containerd that referenced this pull request Jan 17, 2023
Signed-off-by: Maksym Pavlenko <[email protected]>
@mxpv mxpv added cherry-picked/sbserver Changes are backported to sbserver and removed cherry-pick/sbserver labels Jan 19, 2023
jsturtevant pushed a commit to jsturtevant/containerd that referenced this pull request Sep 21, 2023
Signed-off-by: Maksym Pavlenko <[email protected]>
kiashok pushed a commit to kiashok/containerd that referenced this pull request Oct 23, 2024
Signed-off-by: Maksym Pavlenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/sbserver Changes are backported to sbserver needs-ok-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants