Fix sandbox API when calling sandboxed shims#7684
Merged
fuweid merged 4 commits intocontainerd:mainfrom Nov 28, 2022
Merged
Conversation
Closed
17 tasks
Member
Author
|
/test pull-containerd-sandboxed-node-e2e |
dcantah
reviewed
Nov 18, 2022
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
All pause container object references must be removed from sbserver. This is an implementation detail of podsandbox package. Added TODOs for remaining work. Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
dcantah
approved these changes
Nov 27, 2022
fuweid
approved these changes
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes sandbox API so it can properly call sandboxed shims.
Also refactored and removed duplicated code from
podsandboxpackage.--
Added a few commits to further decouple sbserver from pause container (and left bunch of todos for the remaining work)