fix build containerd in centos9#7683
Conversation
|
Hi @yanggangtony. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| * CentOS/Fedora: `yum install btrfs-progs-devel` | ||
| * CentOS(CentOS Stream9): there have no btrfs-progs-devel anymore . You should rpm these packages manual for btrfs error on build. | ||
| like : btrfs-progs-5.12.1-2.hs.el8.x86_64.rpm , btrfs-progs-devel-5.12.1-2.hs.el8.x86_64.rpm , libbtrfs-5.12.1-2.hs.el8.x86_64.rpm,libbtrfsutil-5.12.1-2.hs.el8.x86_64.rpm [CentOS Stream9](https://cbs.centos.org/koji/buildinfo?buildID=32944). | ||
| [build err](https://github.com/containerd/containerd/issues/3488). |
There was a problem hiding this comment.
I think we should delete this line and just add it in git message.
| need to satisfy these dependencies in your system: | ||
|
|
||
| * CentOS/Fedora: `yum install btrfs-progs-devel` | ||
| * CentOS(CentOS Stream9): there have no btrfs-progs-devel anymore . You should rpm these packages manual for btrfs error on build. |
There was a problem hiding this comment.
So it is fine to use btrfs-progs as package name here?
There was a problem hiding this comment.
Perhaps the better option is to describe that BTRFS has been deprecated in RHEL / CentOS 7.4, and removed in RHEL/CentOS 9 and up. (see https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/storage_administration_guide/ch-btrfs, and the release notes)
And for those platforms, recommend using the no_btrfs build-flag to build without btrfs support.
There was a problem hiding this comment.
Perhaps the better option is to describe that BTRFS has been deprecated in RHEL / CentOS 7.4, and removed in RHEL/CentOS 9 and up. (see https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/storage_administration_guide/ch-btrfs, and the release notes)
And for those platforms, recommend using the
no_btrfsbuild-flag to build without btrfs support.
@thaJeztah @fuweid
Thanks for review.
It sounds good to me..
I will update the building.md follow the infos..
yanggangtony
force-pushed
the
build-md
branch
from
74dc8f1 to
189384c
Compare
|
@thaJeztah @fuweid |
yanggangtony
force-pushed
the
build-md
branch
from
189384c to
59a3615
Compare
|
I know you've already handled a bunch of comments; I think this is 99% there, but the two links at the end of the sentence about btrfs removal do not look right in the markdown rendered view. I think the first link: Should go on the actual text that starts that sentence; otherwise you are repeating the phrase twice. Just make the first "Btrfs has been deprecated" a link to the article. The second link: Currently is directly after a period character with no spacing and no other text. Maybe add a few words to make it a sentence, like: |
Signed-off-by: yanggang <[email protected]>
yanggangtony
force-pushed
the
build-md
branch
from
59a3615 to
438db09
Compare
@estesp |
6 participants
Signed-off-by: yanggang [email protected]
When i build containerd in CentOS Stream 9 , build err , tips the "btrfs/ioctl.h: No such file or directory"
Follow the docs , and try to install : yum install btrfs-progs-devel
But there have no package for centos9 , So search the centos web , for fix the build problem.
I refer the web is
centos
build issue
After i install the rpm , then its fine for me..
