Skip to content

Remove OpenTelementry imports from remotes/docker package#7675

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
mxpv:deps
Nov 18, 2022
Merged

Remove OpenTelementry imports from remotes/docker package#7675
dmcgowan merged 1 commit intocontainerd:mainfrom
mxpv:deps

Conversation

@mxpv
Copy link
Copy Markdown
Member

@mxpv mxpv commented Nov 16, 2022

Signed-off-by: Maksym Pavlenko [email protected]

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@swagatbora90 swagatbora90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swagatbora90
Copy link
Copy Markdown
Contributor

swagatbora90 commented Nov 18, 2022

@mxpv can we use otel-http to trace outgoing http requests here, instead of creating manual spans?
I have a PR #7692 that wraps the existing http handler on the CRI stream server side and produces traces for all incoming requests.

@mxpv
Copy link
Copy Markdown
Member Author

mxpv commented Nov 18, 2022

@swagatbora90 No, the goal was to just isolate dependencies here.

@dmcgowan dmcgowan merged commit 6e0f1bb into containerd:main Nov 18, 2022
@mxpv mxpv deleted the deps branch November 18, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants