Skip to content

Release: add static binaries#7659

Merged
estesp merged 1 commit intocontainerd:mainfrom
AkihiroSuda:static-release
Nov 14, 2022
Merged

Release: add static binaries#7659
estesp merged 1 commit intocontainerd:mainfrom
AkihiroSuda:static-release

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

Fix #7296

@estesp
Copy link
Copy Markdown
Member

estesp commented Nov 11, 2022

Do we need to make any statement about support or limitations of this additional delivery (for example, this doesn't provide a static runc in the other tarballs that are created at release)?

@AkihiroSuda
Copy link
Copy Markdown
Member Author

this doesn't provide a static runc in the other tarballs that are created at release

runc isn't included in the existing dynamic containerd-*.tar.gz releases.

runc is included in the cri-containerd-*.tar.gz releases, but cri-containerd-*.tar.gz releases have been deprecated and will be removed in 2.0: https://github.com/containerd/containerd/blob/main/RELEASES.md#deprecated-features
Also documented in https://github.com/containerd/containerd/blob/main/docs/getting-started.md#step-1-installing-containerd

@AkihiroSuda
Copy link
Copy Markdown
Member Author

Also planning to append "Which file should I download?" section to the release note toml

@estesp
Copy link
Copy Markdown
Member

estesp commented Nov 11, 2022

runc is included in the cri-containerd-*.tar.gz releases, but cri-containerd-*.tar.gz releases have been deprecated and will be removed in 2.0: https://github.com/containerd/containerd/blob/main/RELEASES.md#deprecated-features Also documented in https://github.com/containerd/containerd/blob/main/docs/getting-started.md#step-1-installing-containerd

Ah, right.. I was thinking of the cri-* tarballs; makes sense.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp
Copy link
Copy Markdown
Member

estesp commented Nov 11, 2022

Do we need to test this change in a fork to make sure that one some architecture pair we aren't missing a dep for make static?

@AkihiroSuda
Copy link
Copy Markdown
Member Author

@AkihiroSuda
Copy link
Copy Markdown
Member Author

@AkihiroSuda AkihiroSuda marked this pull request as draft November 11, 2022 16:19
@AkihiroSuda AkihiroSuda marked this pull request as ready for review November 11, 2022 17:19
Fix issue 7296

Signed-off-by: Akihiro Suda <[email protected]>
Copy link
Copy Markdown
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit af37da7 into containerd:main Nov 14, 2022
@AkihiroSuda AkihiroSuda requested a review from dmcgowan November 14, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release: add static binaries

5 participants