Add referrers fetcher to remotes #7644
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
dmcgowan
force-pushed
the
remote-referrers
branch
3 times, most recently
from
724b435 to
7b349f3
Compare
kevpar
reviewed
Nov 10, 2022
| ocispec "github.com/opencontainers/image-spec/specs-go/v1" | ||
| ) | ||
|
|
||
| func (r dockerFetcher) FetchReferrers(ctx context.Context, dgst digest.Digest, artifactTypes ...string) (io.ReadCloser, ocispec.Descriptor, error) { |
Member
There was a problem hiding this comment.
This is pretty low-level access to referrers info. Should this provide a higher level view, or be wrapped by something else? It also seems kind of weird to return a descriptor here, doesn't look like it's doing much.
- Paging
- Ensuring filtering is applied (if registry does not support filtering, or if referrers tag schema was used)
- Parsing the output to return a set of descriptors rather than an
io.ReadCloser
Member
Author
There was a problem hiding this comment.
I'm thinking artifactTypes ...string could change to a more generic application including pages if needed. I don't think paging is a good API for referrers though and whether we should support it. Descriptor annotations are good for extra context though (paging, which endpoint, whether filters were applied, etc)
Member
There was a problem hiding this comment.
I think not supporting paging for now is fine, we can always revisit later. Given that filtering by artifact type is not guaranteed to be supported, it would be nice if we provided client-side filtering here as a fallback.
3 tasks
AkihiroSuda
reviewed
Nov 10, 2022
remotes/docker/referrers_test.go
Outdated
| func (ti testIndex) OCIManifest() []byte { | ||
| manifest := ocispec.Index{ | ||
| Versioned: specs.Versioned{ | ||
| SchemaVersion: 1, |
Adds an implementation of the referrers API targeted for OCI distribution-spec 1.1. Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
remote-referrers
branch
from
7b349f3 to
a67a399
Compare
imeoer
added a commit
to imeoer/nydus-snapshotter
that referenced
this pull request
Mar 31, 2023
Add the new `enable_referrers` option in config.toml, to enables trying to fetch the nydus image associated with the OCI image and run it. This feature relies on the support of OCI reference type. Currently, only Harbor (>=v2.8) registry and ORAS registry support this. Additionally, we need to rely on containerd's referrer fetcher interface, related links: containerd/containerd#7644 https://oras.land/cli/6_reference_types/ Signed-off-by: Yan Song <[email protected]>
imeoer
added a commit
to imeoer/nydus-snapshotter
that referenced
this pull request
Mar 31, 2023
Add the new `enable_referrers` option in config.toml, to enables trying to fetch the nydus image associated with the OCI image and run it. This feature relies on the support of OCI reference type. Currently, only Harbor (>=v2.8) registry and ORAS registry support this. Additionally, we need to rely on containerd's referrer fetcher interface, related links: containerd/containerd#7644 https://oras.land/cli/6_reference_types/ Signed-off-by: Yan Song <[email protected]>
imeoer
added a commit
to imeoer/nydus-snapshotter
that referenced
this pull request
Mar 31, 2023
Add the new `enable_referrers` option in config.toml, to enables trying to fetch the nydus image associated with the OCI image and run it. This feature relies on the support of OCI reference type. Currently, only Harbor (>=v2.8) registry and ORAS registry support this. Additionally, we need to rely on containerd's referrer fetcher interface, related links: containerd/containerd#7644 https://oras.land/cli/6_reference_types/ Signed-off-by: Yan Song <[email protected]>
imeoer
added a commit
to imeoer/nydus-snapshotter
that referenced
this pull request
Mar 31, 2023
Add the new `enable_referrers` option in config.toml, to enables trying to fetch the nydus image associated with the OCI image and run it. This feature relies on the support of OCI reference type. Currently, only Harbor (>=v2.8) registry and ORAS registry support this. Additionally, we need to rely on containerd's referrer fetcher interface, related links: containerd/containerd#7644 https://oras.land/cli/6_reference_types/ Signed-off-by: Yan Song <[email protected]>
imeoer
added a commit
to imeoer/nydus-snapshotter
that referenced
this pull request
Apr 6, 2023
Add the new `enable_referrers` option in config.toml, to enables trying to fetch the nydus image associated with the OCI image and run it. This feature relies on the support of OCI reference type. Currently, only Harbor (>=v2.8) registry and ORAS registry support this. Additionally, we need to rely on containerd's referrer fetcher interface, related links: containerd/containerd#7644 https://oras.land/cli/6_reference_types/ Signed-off-by: Yan Song <[email protected]>
imeoer
added a commit
to imeoer/nydus-snapshotter
that referenced
this pull request
Apr 6, 2023
Add the new `enable_referrers` option in config.toml, to enables trying to fetch the nydus image associated with the OCI image and run it. This feature relies on the support of OCI reference type. Currently, only Harbor (>=v2.8) registry and ORAS registry support this. Additionally, we need to rely on containerd's referrer fetcher interface, related links: containerd/containerd#7644 https://oras.land/cli/6_reference_types/ Signed-off-by: Yan Song <[email protected]>
imeoer
added a commit
to imeoer/nydus-snapshotter
that referenced
this pull request
Apr 10, 2023
Add the new `enable_referrers` option in config.toml, to enables trying to fetch the nydus image associated with the OCI image and run it. This feature relies on the support of OCI reference type. Currently, only Harbor (>=v2.8) registry and ORAS registry support this. Additionally, we need to rely on containerd's referrer fetcher interface, related links: containerd/containerd#7644 https://oras.land/cli/6_reference_types/ Signed-off-by: Yan Song <[email protected]>
imeoer
added a commit
to imeoer/nydus-snapshotter
that referenced
this pull request
Apr 14, 2023
Add the new `enable_referrers` option in config.toml, to enables trying to fetch the nydus image associated with the OCI image and run it. This feature relies on the support of OCI reference type. Currently, only Harbor (>=v2.8) registry and ORAS registry support this. Additionally, we need to rely on containerd's referrer fetcher interface, related links: containerd/containerd#7644 https://oras.land/cli/6_reference_types/ Signed-off-by: Yan Song <[email protected]>
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 7 days unless new comments are made or the stale label is removed. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an implementation of the referrers API targeted for OCI distribution-spec 1.1.
Note: The draft spec specifies that registries MUST return all referrers, even if that list grows beyond a useful size. To accommodate large list there is pagination. The pagination doesn't fit well into our API or storage model but we should figure out something there.