Skip to content

Bump grpc to v1.50.1 #7643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fuweid merged 1 commit into from
Nov 11, 2022
Merged

Bump grpc to v1.50.1 #7643

fuweid merged 1 commit into from
Nov 11, 2022

Conversation

@lucacome
Copy link
Contributor

@lucacome lucacome commented Nov 8, 2022

  • Bumps grpc to v1.50.1
  • Bumps protobuf to v1.28.1
  • Bumps genproto to v0.0.0-20221107162902-2d387536bcdd

@k8s-ci-robot
Copy link

k8s-ci-robot commented Nov 8, 2022

Hi @lucacome. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lucacome
Copy link
Contributor Author

lucacome commented Nov 8, 2022

I have a PR open in kubernetes to bump grpc there too kubernetes/kubernetes#113707

kzys
kzys approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@kzys
Copy link
Member

kzys commented Nov 9, 2022

/retest

2 similar comments
@samuelkarp
Copy link
Member

samuelkarp commented Nov 9, 2022

/retest

@lucacome
Copy link
Contributor Author

lucacome commented Nov 9, 2022

/retest

@fuweid
Copy link
Member

fuweid commented Nov 10, 2022

grpc/grpc-go#5782 it seems that we can wait for 1.51 😅 if the CI is still unhappy 😞

@Burning1020 Burning1020 mentioned this pull request Nov 10, 2022
Merged
@lucacome
Bump grpc to v1.50.1
ab194e6 
Signed-off-by: Luca Comellini <[email protected]>
@fuweid
Copy link
Member

fuweid commented Nov 11, 2022

/retest

@fuweid fuweid merged commit b5253df into containerd:main Nov 11, 2022
@lucacome lucacome deleted the bump-grpc branch November 11, 2022 04:27
@thaJeztah thaJeztah mentioned this pull request Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@fuweid fuweid fuweid approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lucacome @k8s-ci-robot @kzys @samuelkarp @fuweid @AkihiroSuda @dcantah