Skip to content

Extra documentation for content interfaces#7640

Merged
estesp merged 1 commit intocontainerd:mainfrom
nikitar:main
Nov 8, 2022
Merged

Extra documentation for content interfaces#7640
estesp merged 1 commit intocontainerd:mainfrom
nikitar:main

Conversation

@nikitar
Copy link
Copy Markdown
Contributor

@nikitar nikitar commented Nov 8, 2022

Also moved the main interface (Store) to the top of the file and grouped some related interfaces together.

Fixes: #7305

Signed-off-by: Nikita Rybak [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Nov 8, 2022

Hi @nikitar. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikitar
Copy link
Copy Markdown
Contributor Author

nikitar commented Nov 8, 2022

How does one rerun CI tests to ensure a failure is due to random flakiness? Usually I see an option to rerun a workflow in the github ui (along these lines), but not here.

I don't imagine a failure of "Windows Integration (windows-2022, sandboxed)" is related to this, but wanted to be certain.

estesp
estesp approved these changes Nov 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit b850554 into containerd:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

documentation for Ingester interface in containerd

4 participants

@nikitar @k8s-ci-robot @estesp @AkihiroSuda