Skip to content

[release/1.6] Backport LogURIGenerator fixes for Windows. (#7351 and #7569)#7632

Closed
aznashwan wants to merge 2 commits intocontainerd:release/1.6from
aznashwan:1.6-backport-win-log-uri
Closed

[release/1.6] Backport LogURIGenerator fixes for Windows. (#7351 and #7569)#7632
aznashwan wants to merge 2 commits intocontainerd:release/1.6from
aznashwan:1.6-backport-win-log-uri

Conversation

@aznashwan
Copy link
Contributor

@aznashwan aznashwan commented Nov 4, 2022

#7351 is a minor but important fix to cio.LogURIGenerator which is needed to enable container logging in nerdctl on Windows, while #7569 contains some fixes to unit tests for it.

Kazuyoshi Kato and others added 2 commits November 4, 2022 10:43
@aznashwan
Fix LogURIGenerator on Windows
0e56abb 
Checking / is not the right way to distinguish an absolute path in
Windows.

Fixes containerd#5786.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@aznashwan
Fix LogURI generation-related tests on Windows.
6af7f3e 
Signed-off-by: Nashwan Azhari <[email protected]>
@k8s-ci-robot
Copy link

k8s-ci-robot commented Nov 4, 2022

Hi @aznashwan. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aznashwan aznashwan mentioned this pull request Nov 4, 2022
Merged
@aznashwan
Copy link
Contributor Author

aznashwan commented Nov 4, 2022

This was created following a misunderstanding on my end on which containerd tag nerdctl should be referencing in its go.mod here.

Sorry for the confusion, closing now...

@aznashwan aznashwan closed this Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aznashwan @k8s-ci-robot