Skip to content

s390x: build and package s390x bin in release assets#7614

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
huoqifeng:s390x
Nov 7, 2022
Merged

s390x: build and package s390x bin in release assets#7614
dmcgowan merged 1 commit intocontainerd:mainfrom
huoqifeng:s390x

Conversation

@huoqifeng
Copy link
Copy Markdown

Fix: #7612 , there is nightly build available for s390x, could we package it in release assets without testing same as other projects which are lack of s390x machine for testing?

Signed-off-by: huoqifeng [email protected]

Signed-off-by: huoqifeng <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

Hi @huoqifeng. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AdamKorcz
Copy link
Copy Markdown
Contributor

The CI Fuzz issue should have been fixed.

@huoqifeng
Copy link
Copy Markdown
Author

Thank you @AdamKorcz do you know how to rebuild the CI jobs? I don't see updates in main branch.

@AdamKorcz
Copy link
Copy Markdown
Contributor

Thank you @AdamKorcz do you know how to rebuild the CI jobs? I don't see updates in main branch.

I don't, sorry.

@dcantah
Copy link
Copy Markdown
Member

dcantah commented Nov 1, 2022

@huoqifeng You can close+re-open the PR to re-run, or wait for a maintainer to re-kick them off

@dcantah
Copy link
Copy Markdown
Member

dcantah commented Nov 2, 2022

Seems there's a merge commit included in this PR now, could you remove this and just have the commit for this change? Generally if you want to get on top of main you'd rebase your PRs changes on top and re-push

@kzys
Copy link
Copy Markdown
Member

kzys commented Nov 7, 2022

/ok-to-test

@dmcgowan dmcgowan merged commit d1564fe into containerd:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build and release linux s390x architecture binaries

6 participants