Skip to content

Generate proto services with go-ttrpc#7609

Merged
mxpv merged 2 commits intocontainerd:mainfrom
dmcgowan:generate-ttrpc-services
Feb 22, 2024
Merged

Generate proto services with go-ttrpc#7609
mxpv merged 2 commits intocontainerd:mainfrom
dmcgowan:generate-ttrpc-services

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

This provides go bindings for our services using go-ttrpc and shares the same types used for existing grpc services.

@k8s-ci-robot
Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dmcgowan dmcgowan force-pushed the generate-ttrpc-services branch 3 times, most recently from 552e9b5 to 0b104cd Compare October 31, 2022 22:21
@dmcgowan dmcgowan force-pushed the generate-ttrpc-services branch 2 times, most recently from da799ae to 5ad0d40 Compare December 23, 2022 01:44
@dmcgowan dmcgowan force-pushed the generate-ttrpc-services branch from 5ad0d40 to 765af5f Compare February 21, 2024 22:20
@dmcgowan dmcgowan force-pushed the generate-ttrpc-services branch from 765af5f to f0e8749 Compare February 21, 2024 22:22
@dmcgowan dmcgowan added this to the 2.0 milestone Feb 21, 2024
@dmcgowan dmcgowan marked this pull request as ready for review February 21, 2024 22:28
@dmcgowan dmcgowan requested review from dcantah, fuweid and mxpv February 22, 2024 05:52
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxpv mxpv added this pull request to the merge queue Feb 22, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 22, 2024
@mxpv mxpv added this pull request to the merge queue Feb 22, 2024
Merged via the queue into containerd:main with commit 65588b5 Feb 22, 2024
@dmcgowan dmcgowan deleted the generate-ttrpc-services branch April 20, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants