Add sequence diagram for shim runtime v2#7606
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom Nov 1, 2022
Merged
Conversation
Signed-off-by: Maksym Pavlenko <[email protected]>
jterry75
reviewed
Nov 1, 2022
| containerd->>shim: TaskService.CreateTaskRequest | ||
| shim-->>containerd: Task PID | ||
|
|
||
| containerd-->>ctr: Task ID |
Contributor
There was a problem hiding this comment.
Oh containerd to CTR. I get it now lol
jterry75
reviewed
Nov 1, 2022
| ctr->>containerd: Wait task | ||
|
|
||
| containerd->>shim: TaskService.WaitRequest | ||
| Note right of shim: Block until task exits |
Contributor
There was a problem hiding this comment.
Important to call out that this protocol basically requires TTRPC with a zero timeout here or the block would not be infinite like we rely on here.
dmcgowan
approved these changes
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates runtime v2 README with sequence diagram to show flow of shim requests when running a container. I plan to add another one to depict flow with sandbox API, but it took me longer then I expected.
Rendered version
Signed-off-by: Maksym Pavlenko [email protected]