Skip to content

Fix missing closed fifo#7604

Merged
mxpv merged 1 commit intocontainerd:mainfrom
wzshiming:fix/close-fifo
Nov 4, 2022
Merged

Fix missing closed fifo#7604
mxpv merged 1 commit intocontainerd:mainfrom
wzshiming:fix/close-fifo

Conversation

@wzshiming
Copy link
Copy Markdown
Contributor

@wzshiming wzshiming commented Oct 31, 2022

No description provided.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Oct 31, 2022

Hi @wzshiming. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dcantah
dcantah approved these changes Oct 31, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Change looks unrelated to CI failure but someone will need to re-kick this off

@kzys
Copy link
Copy Markdown
Member

kzys commented Nov 3, 2022

/ok-to-test

@wzshiming
Fix missing closed fifo
c607f83 
Signed-off-by: Shiming Zhang <[email protected]>
@wzshiming
Copy link
Copy Markdown
Contributor Author

wzshiming commented Nov 4, 2022

Shim v2 seems to have the same problem, I'll fix it together

@wzshiming wzshiming requested review from dcantah and kzys and removed request for kzys November 4, 2022 02:16
@mxpv mxpv merged commit 525fe21 into containerd:main Nov 4, 2022
@wzshiming wzshiming deleted the fix/close-fifo branch November 4, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@mxpv mxpv mxpv approved these changes

@dcantah dcantah Awaiting requested review from dcantah

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wzshiming @k8s-ci-robot @kzys @mxpv @dcantah