Sandbox API: Move remote impls to /sandbox/proxy#7600
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom Nov 1, 2022
Merged
Sandbox API: Move remote impls to /sandbox/proxy#7600dmcgowan merged 1 commit intocontainerd:mainfrom
dmcgowan merged 1 commit intocontainerd:mainfrom
Conversation
Following how some of the other stores/services are returned in the client package, it makes sense to me to move the remoteFooBars in the sandbox API to a proxy sub-package under /sandbox. Given this has only been in a 1.7 beta, I hope this is fine to move around still. Signed-off-by: Danny Canter <[email protected]>
Member
Author
|
Related to #7312 |
samuelkarp
approved these changes
Oct 29, 2022
Member
Author
|
Sorry for the close here. @mxpv Let me know if this looks alright as the sandbox expert |
Member
|
/test pull-containerd-node-e2e |
mxpv
approved these changes
Nov 1, 2022
dmcgowan
approved these changes
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following how some of the other stores/services are returned in the client package, it makes sense to me to move the remoteFooBars in the sandbox API to a proxy sub-package under /sandbox. Given this has only been in a 1.7 beta, I hope this is fine to move around still.