maintenance: Remove WithWindowsNetworkNamespace from pkg/cri#7577
Merged
mxpv merged 1 commit intocontainerd:mainfrom Oct 23, 2022
Merged
maintenance: Remove WithWindowsNetworkNamespace from pkg/cri#7577mxpv merged 1 commit intocontainerd:mainfrom
mxpv merged 1 commit intocontainerd:mainfrom
Conversation
Old TODO stating that pkg/cri/opts's `WithWindowsNetworkNamespace` should be moved to the main containerd pkg was out of date as thats already been done (well, to the /oci package). This just removes it and swaps all uses of `WithWindowsNetworkNamespace` to the oci packages impl. Signed-off-by: Danny Canter <[email protected]>
mxpv
approved these changes
Oct 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was perusing around for a different TODO and saw one in pkg/cri/opts that stated that
WithWindowsNetworkNamespaceshould be moved to the main containerd pkg. This was done in #6304 already (well, to the /oci pkg) so we're good to get rid of the CRI version. This additionally swaps all uses ofWithWindowsNetworkNamespaceto the oci packages impl.