Skip to content

[release/1.6] adding support of CAP_BPF and CAP_PERFMON#7574

Merged
dmcgowan merged 1 commit intocontainerd:release/1.6from
swagatbora90:backport-cap-bpf-perfmon
Oct 24, 2022
Merged

[release/1.6] adding support of CAP_BPF and CAP_PERFMON#7574
dmcgowan merged 1 commit intocontainerd:release/1.6from
swagatbora90:backport-cap-bpf-perfmon

Conversation

@swagatbora90
Copy link
Copy Markdown
Contributor

@swagatbora90 swagatbora90 commented Oct 22, 2022

This PR is to cherry-pick #7301 "Adding support of CAP_BPF and CAP_PERFMON "

@henry118 @swagatbora90
adding support of CAP_BPF and CAP_PERFMON
346412f 
Signed-off-by: Henry Wang <[email protected]>
(cherry picked from commit 4390751)
Signed-off-by: Swagat Bora <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Oct 22, 2022

Hi @swagatbora90. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swagatbora90 swagatbora90 changed the title adding support of CAP_BPF and CAP_PERFMON [release/1.6] adding support of CAP_BPF and CAP_PERFMON Oct 22, 2022
@swagatbora90
Copy link
Copy Markdown
Contributor Author

swagatbora90 commented Oct 22, 2022 •
edited
Loading

/cc @kzys

@samuelkarp
Copy link
Copy Markdown
Member

samuelkarp commented Oct 22, 2022

/ok-to-test

samuelkarp
samuelkarp approved these changes Oct 22, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's hold off on merging this until after 1.6.9.

dcantah
dcantah approved these changes Oct 23, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swagatbora90
Copy link
Copy Markdown
Contributor Author

swagatbora90 commented Oct 23, 2022 •
edited
Loading

LGTM, but let's hold off on merging this until after 1.6.9

@samuelkarp thanks for cutting the new release. Will it be possible to get this change into 1.6.9?

estesp
estesp approved these changes Oct 24, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I think this is reasonable to pull into the 1.6.9 tag given it is part of us keeping up with the ecosystem/kernel features.

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Oct 24, 2022

I think we can get this pulled in before cutting the release

@dmcgowan dmcgowan merged commit 96929a5 into containerd:release/1.6 Oct 24, 2022
@swagatbora90 swagatbora90 deleted the backport-cap-bpf-perfmon branch October 24, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@estesp estesp estesp approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@swagatbora90 @k8s-ci-robot @samuelkarp @dmcgowan @estesp @dcantah @henry118