Skip to content

Fix LogURI generation-related tests on Windows.#7569

Merged
kzys merged 1 commit intocontainerd:mainfrom
aznashwan:cio-loguri-windows
Oct 24, 2022
Merged

Fix LogURI generation-related tests on Windows.#7569
kzys merged 1 commit intocontainerd:mainfrom
aznashwan:cio-loguri-windows

Conversation

@aznashwan
Copy link
Contributor

Signed-off-by: Nashwan Azhari [email protected]

@k8s-ci-robot
Copy link

Hi @aznashwan. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aznashwan
Copy link
Contributor Author

aznashwan commented Oct 21, 2022

Context: this test was technically a false positive on all platforms as it was accidentally calling assert.Error() which simply checks whether the given error is != nil. (which it always was by the point assert.Error() was called, so none of the tests which yielded errors ever failed, regardless if the errors were expected or not)
Switching to assert.ErrorContains() should achieve the original purpose of the test.

Note that I have also added separate testcases for *nix and Windows as we use filepath.IsAbs() which only works on paths for the given platform we're running on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants