Skip to content

Use go env to determine GOPATH in Makefile.#7542

Merged
estesp merged 1 commit intocontainerd:mainfrom
aznashwan:makefile-gopath
Oct 17, 2022
Merged

Use go env to determine GOPATH in Makefile.#7542
estesp merged 1 commit intocontainerd:mainfrom
aznashwan:makefile-gopath

Conversation

@aznashwan
Copy link
Copy Markdown
Contributor

Signed-off-by: Nashwan Azhari [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

Hi @aznashwan. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aznashwan
Copy link
Copy Markdown
Contributor Author

Context: I first came across this issue while switching the GitHub workflow in containerd/nerdctl#1393 from bash to PowerShell as the default shell.

When using PowerShell, $env:GOPATH should be used, and $GOPATH will most likely be undefined, leading to this build error. (note the -gcflags=-trimpath=/src when it should actually be -gcflags=-trimpath=$GOPATH/src)

@estesp estesp merged commit 9f6947f into containerd:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants