Skip to content

Conversation

@kzys
Copy link
Member

@kzys kzys commented Oct 14, 2022

This PR improves containerd's testing on GitHub actions, especially around reporting.

The first two commits were upgrading dependencies to reduce version-related warnings. The rest is giving more structures around logging to help developers distinguish which logs are coming from which components.

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Kazuyoshi Kato added 4 commits October 17, 2022 16:27
v2 uses Node.js 12.x which is EOL.

Signed-off-by: Kazuyoshi Kato <[email protected]>
This version up will migrate critools off from Ginkgo 1.x which has been
deprecated.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@kzys kzys force-pushed the critest-ginkgo-v2 branch from 69e1f65 to 8e7ef89 Compare October 17, 2022 16:27
@kzys kzys changed the title [WIP] Test improvements Make tests on GitHub less noisy Oct 17, 2022
@kzys kzys marked this pull request as ready for review October 17, 2022 17:25
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelkarp samuelkarp merged commit e8cdbee into containerd:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants