Skip to content

Stats() shouldn't assume s.container is non-nil#7517

Merged
estesp merged 1 commit intocontainerd:mainfrom
kzys:stats-nil
Oct 13, 2022
Merged

Stats() shouldn't assume s.container is non-nil#7517
estesp merged 1 commit intocontainerd:mainfrom
kzys:stats-nil

Conversation

@kzys
Copy link
Copy Markdown
Member

@kzys kzys commented Oct 12, 2022

Like other exported methods, Stats() shouldn't assume s.container is non-nil.

Fixes #7468.

@k8s-ci-robot
Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Like other exported methods, Stats() shouldn't assume s.container is
non-nil.

Fixes containerd#7468.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@kzys kzys marked this pull request as ready for review October 12, 2022 22:24
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 330df47 into containerd:main Oct 13, 2022
@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah added cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch and removed cherry-pick/1.5.x labels Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

containerd sometimes crashes with panic: runtime error: invalid memory address or nil pointer dereference

6 participants