Skip to content

[release/1.6] Update container with sandbox metadata after NetNS is created#7505

Merged
samuelkarp merged 1 commit intocontainerd:release/1.6from
qiutongs:backport-netns-1.6
Oct 11, 2022
Merged

[release/1.6] Update container with sandbox metadata after NetNS is created#7505
samuelkarp merged 1 commit intocontainerd:release/1.6from
qiutongs:backport-netns-1.6

Conversation

@qiutongs
Copy link
Copy Markdown
Contributor

@qiutongs qiutongs commented Oct 11, 2022

Backport #7481 to release/1.6

Testing

ENABLE_CRI_SANDBOXES="" CONTAINERD_RUNTIME=runc FOCUS=TestRunPodSandboxAndTeardownCNISlow make cri-integration

Signed-off-by: Qiutong Song <[email protected]>
(cherry picked from commit b41d6f4)
Signed-off-by: Qiutong Song <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

Hi @qiutongs. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@samuelkarp
Copy link
Copy Markdown
Member

/ok-to-test

@samuelkarp samuelkarp added kind/bug area/cri Container Runtime Interface (CRI) labels Oct 11, 2022
@samuelkarp samuelkarp added this to the 1.6.9 milestone Oct 11, 2022
@qiutongs
Copy link
Copy Markdown
Contributor Author

/cc @fuweid @samuelkarp @estesp

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cri Container Runtime Interface (CRI) kind/bug ok-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants