Skip to content

bump go-fuzz-headers#7503

Merged
kzys merged 1 commit intocontainerd:mainfrom
AdamKorcz:fuzz1
Oct 19, 2022
Merged

bump go-fuzz-headers#7503
kzys merged 1 commit intocontainerd:mainfrom
AdamKorcz:fuzz1

Conversation

@AdamKorcz
Copy link
Copy Markdown
Contributor

@AdamKorcz AdamKorcz commented Oct 10, 2022

Get latest updates from go-fuzz-headers.

@kzys

Signed-off-by: AdamKorcz [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Oct 10, 2022

Hi @AdamKorcz. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estesp
Copy link
Copy Markdown
Member

estesp commented Oct 10, 2022

The CI run got a different go.sum than your PR commit; can you verify with go mod tidy on your end and re-push? Otherwise, it might be a Go version issue (CI is running with 1.19 now)

@AdamKorcz AdamKorcz force-pushed the fuzz1 branch 2 times, most recently from 254a8c8 to 573b5a9 Compare October 11, 2022 22:23
@samuelkarp
Copy link
Copy Markdown
Member

samuelkarp commented Oct 11, 2022

Looks like the same failure in CI, but this time in the integration/client folder. Can you run go mod tidy in that folder too?

@kzys
Copy link
Copy Markdown
Member

kzys commented Oct 12, 2022

The change looks good. Please exclude Justin's commit from your PR. You can rebase your branch instead of merging his change in.

@samuelkarp samuelkarp added the status/needs-update Awaiting contributor update label Oct 17, 2022
@AdamKorcz AdamKorcz closed this Oct 18, 2022
@AdamKorcz AdamKorcz reopened this Oct 18, 2022
@AdamKorcz
bump go-fuzz-headers
9a8611d 
Signed-off-by: AdamKorcz <[email protected]>
@estesp estesp removed needs-ok-to-test status/needs-update Awaiting contributor update labels Oct 19, 2022
estesp
estesp approved these changes Oct 19, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzys kzys merged commit 3bfa855 into containerd:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AdamKorcz @k8s-ci-robot @estesp @samuelkarp @kzys @dmcgowan