runtime/v2/shim: clean up the use of containerdBinary#7499
runtime/v2/shim: clean up the use of containerdBinary#7499AkihiroSuda merged 1 commit intocontainerd:mainfrom
Conversation
|
Hi @Iceber. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Iceber
force-pushed
the
cleanup_shim_flag
branch
from
6afdff7 to
c872c5c
Compare
Signed-off-by: Iceber Gu <[email protected]>
Iceber
force-pushed
the
cleanup_shim_flag
branch
from
c872c5c to
b7f6a68
Compare
|
/retest |
|
@Iceber: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
6 participants
The shim based on the file shim/shim.go no longer needs to use public flag to publish events, instead using the
TTRPC_ADDRESSenvironment variable, we can remove the meaningless use of containerdBinaryOf course, for compatibility we still need to support
--publish-binaryflag.