TestTaskResize must use a terminal#7492
Merged
mxpv merged 1 commit intocontainerd:mainfrom Oct 10, 2022
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
kzys
force-pushed
the
task-resize
branch
4 times, most recently
from
459ab08 to
f26816d
Compare
The test was essentially no-op since it didn't use a terminal. Fixes containerd#6249. Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
changed the title
Member
Author
|
@cpuguy83 Can you take a look? |
cpuguy83
approved these changes
Oct 10, 2022
Member
cpuguy83
left a comment
cpuguy83
left a comment
There was a problem hiding this comment.
Wow, I forgot about this, thanks for looking into it!
LGTM
mxpv
approved these changes
Oct 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was essentially no-op since it didn't use a terminal.
Fixes #6249.
Signed-off-by: Kazuyoshi Kato [email protected]