Skip to content

CI: update GHA instances from Ubuntu 18.04 to 20.04#7489

Merged
kzys merged 1 commit intocontainerd:mainfrom
AkihiroSuda:switch-away-from-ubuntu-18.04
Oct 13, 2022
Merged

CI: update GHA instances from Ubuntu 18.04 to 20.04#7489
kzys merged 1 commit intocontainerd:mainfrom
AkihiroSuda:switch-away-from-ubuntu-18.04

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda commented Oct 7, 2022 •
edited
Loading

@AkihiroSuda

This comment was marked as resolved.

Sign in to view
@AkihiroSuda AkihiroSuda force-pushed the switch-away-from-ubuntu-18.04 branch 2 times, most recently from fa434b1 to 2cd2d7b Compare October 7, 2022 05:44
@AkihiroSuda AkihiroSuda marked this pull request as draft October 7, 2022 05:48
@AkihiroSuda AkihiroSuda force-pushed the switch-away-from-ubuntu-18.04 branch 2 times, most recently from 01f8f92 to 006fbf2 Compare October 7, 2022 06:18
@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Oct 7, 2022

CRI tests are failing 😥

=== RUN   TestSandboxRemoveWithoutIPLeakage
    sandbox_clean_remove_test.go:39: Make sure host-local ipam is in use
    sandbox_clean_remove_test.go:52: Create a sandbox
    sandbox_clean_remove_test.go:62: Get pod information
    sandbox_clean_remove_test.go:76: Should be able to find the pod ip in host-local checkpoint
    sandbox_clean_remove_test.go:89: Kill sandbox container
    sandbox_clean_remove_test.go:92: Unmount network namespace
    sandbox_clean_remove_test.go:95: Network namespace should be closed
    sandbox_clean_remove_test.go:100: Remove network namespace
    sandbox_clean_remove_test.go:103: Network namespace should still be closed
    sandbox_clean_remove_test.go:105: 
        	Error Trace:	/home/runner/work/containerd/containerd/sandbox_clean_remove_test.go:105
        	Error:      	Received unexpected error:
        	            	failed to get sandbox status: rpc error: code = NotFound desc = failed to get verbose sandbox container info: failed to get task status: container not created: not found
        	Test:       	TestSandboxRemoveWithoutIPLeakage
--- FAIL: TestSandboxRemoveWithoutIPLeakage (0.25s)

@AkihiroSuda
CI: update GHA instances from Ubuntu 18.04 to 20.04
ea53e52 
The release binaries are built using Ubuntu 18.04 in Docker on Ubuntu 20.04
for glibc compatibility reason (issue 7255).

Fix issue 7297

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda force-pushed the switch-away-from-ubuntu-18.04 branch from 006fbf2 to ea53e52 Compare October 13, 2022 00:55
@AkihiroSuda AkihiroSuda marked this pull request as ready for review October 13, 2022 05:30
@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Oct 13, 2022

Restarted CI and now green

estesp
estesp approved these changes Oct 13, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzys kzys merged commit 766e933 into containerd:main Oct 13, 2022
@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Jan 24, 2023

Looks like this was cherry-picked as part of #7713

@thaJeztah thaJeztah added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch and removed cherry-pick/1.6.x labels Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GHA: ubuntu-18.04 will be unsupported by 12/1/22

4 participants

@AkihiroSuda @thaJeztah @kzys @estesp