Updates oci image config to support upstream ArgsEscaped#7483
Conversation
|
Hi @jterry75. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kevpar
left a comment
kevpar
left a comment
There was a problem hiding this comment.
LGTM. Nice that we can do this now :)
|
/lgtm |
|
Per CI, maybe needs a |
|
/ok-to-test |
|
ping @jterry -- looks like this is good, but needs a |
jterry75
force-pushed
the
jterry75/update_image_config_argsescaped
branch
from
abab1e8 to
b66e558
Compare
|
My bad folks, got distracted. Updated the go.sum file. |
|
Sorry; also need to run the |
|
Golang.... |
ArgsEscaped has now been merged into upstream OCI image spec. This change removes the workaround we were doing in containerd to deserialize the extra json outside of the spec and instead just uses the formal spec types. Signed-off-by: Justin Terry <[email protected]>
jterry75
force-pushed
the
jterry75/update_image_config_argsescaped
branch
from
b66e558 to
d4b9dad
Compare
|
Yay! Thanks @jterry75! |
|
I'm just happy it didn't go over 1 year! Ty all |
9 participants
ArgsEscaped has now been merged into upstream OCI image spec. This change removes the workaround we were doing in containerd to deserialize the extra json outside of the spec and instead just uses the formal spec types.
Signed-off-by: Justin Terry [email protected]