[release/1.5] retry request on writer reset#7479
[release/1.5] retry request on writer reset#7479estesp merged 2 commits intocontainerd:release/1.5from
Conversation
|
Hi @akhilerm. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
akhilerm
changed the title
akhilerm
force-pushed
the
cherry-pick-6995-1.5
branch
2 times, most recently
from
637ff9b to
fd0f406
Compare
|
I don't know how to fix the overall status, but this PR has passed CI. I found 2 PRs with no GH Actions status from 11+ hours ago--both were in some hung/pending state with no jobs ever run. I had to manually use the actions management view to cancel both of them and then do a "re-run all jobs"; after that all jobs ran and passed, but the "CI / Build failed" entry won't go away and shows a red X for "Run manually canceled". |
|
@estesp Arent the vagrant box tests part of 1.5? Also I will try force pushing to see if that will retrigger the CI. Also, can I get an ok-to-test on this PR? |
akhilerm
force-pushed
the
cherry-pick-6995-1.5
branch
from
fd0f406 to
4a4232f
Compare
|
/ok-to-test |
|
@kzys @samuelkarp Will you be able to look into this PR? |
|
/retest |
|
/test pull-containerd-node-e2e |
2 similar comments
|
/test pull-containerd-node-e2e |
|
/test pull-containerd-node-e2e |
when a put request is retried due to the response from registry, the body of the request should be seekable. A dynamic pipe is added to the body so that the content of the body can be read again. Currently a maximum of 5 resets are allowed, above which will fail the request. A new error ErrReset is introduced which informs that a reset has occured and request needs to be retried. also added tests for Copy() and push() to test the new functionality Signed-off-by: Akhil Mohan <[email protected]> (cherry picked from commit 8f4c23b) Signed-off-by: Akhil Mohan <[email protected]>
Signed-off-by: rongfu.leng <[email protected]> (cherry picked from commit 63a7d8a) Signed-off-by: Akhil Mohan <[email protected]>
akhilerm
force-pushed
the
cherry-pick-6995-1.5
branch
from
28595a3 to
ac1fbc1
Compare
|
/retest |
|
/test pull-containerd-node-e2e-1-5 |
|
/test pull-containerd-node-e2e-1-5 |
|
@akhilerm: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
@dmcgowan @samuelkarp Can this PR be merged now? The failure of |
8 participants
This is not a clean cherry-pick of #6995
cherry-pick #7473 (clean / fix )
when a put request is retried due to the response from registry, the body of the request should be seekable. A dynamic pipe is added to the body so that the content of the body can be read again. Currently a maximum of 5 resets are allowed, above which will fail the request. A new error ErrReset is introduced which informs that a reset has occured and request needs to be retried.
also added tests for Copy() and push() to test the new functionality