Skip to content

fuzzing: create structured tar bytes in archive fuzzer#7477

Merged
fuweid merged 1 commit intocontainerd:mainfrom
AdamKorcz:fuzz1
Oct 5, 2022
Merged

fuzzing: create structured tar bytes in archive fuzzer#7477
fuweid merged 1 commit intocontainerd:mainfrom
AdamKorcz:fuzz1

Conversation

@AdamKorcz
Copy link
Copy Markdown
Contributor

@AdamKorcz AdamKorcz commented Oct 4, 2022

TarBytes has undergone some work with a few more improvements which makes it more suitable for the archive fuzzer.

@kzys

Signed-off-by: AdamKorcz [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Oct 4, 2022

Hi @AdamKorcz. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@samuelkarp
Copy link
Copy Markdown
Member

samuelkarp commented Oct 4, 2022

We may want to merge this after #7474 since the new Go version should contain fixes to archive/tar.

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Oct 4, 2022

They also included a test-tar in their repository (src/archive/tar/testdata/pax-bad-hdr-large.tar.bz2); golang/go@4fa773c

@fuweid fuweid merged commit 31f9d13 into containerd:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@fuweid fuweid fuweid approved these changes

Assignees

No one assigned

Labels

kind/test needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AdamKorcz @k8s-ci-robot @samuelkarp @thaJeztah @fuweid