Skip to content

[release/1.6] Update go 1.18.7, addresses CVE-2022-2879, CVE-2022-2880, CVE-2022-41715#7475

Merged
AkihiroSuda merged 5 commits intocontainerd:release/1.6from
thaJeztah:1.6_bump_go_1.18.7
Oct 5, 2022
Merged

[release/1.6] Update go 1.18.7, addresses CVE-2022-2879, CVE-2022-2880, CVE-2022-41715#7475
AkihiroSuda merged 5 commits intocontainerd:release/1.6from
thaJeztah:1.6_bump_go_1.18.7

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

From the mailing list:

We have just released Go versions 1.19.2 and 1.18.7, minor point releases.

These minor releases include 3 security fixes following the security policy:

  • archive/tar: unbounded memory consumption when reading headers

    Reader.Read did not set a limit on the maximum size of file headers. A maliciously crafted archive could cause Read to allocate unbounded amounts of memory, potentially causing resource exhaustion or panics. Reader.Read now limits the maximum size of header blocks to 1 MiB.

    Thanks to Adam Korczynski (ADA Logics) and OSS-Fuzz for reporting this issue.

    This is CVE-2022-2879 and Go issue https://go.dev/issue/54853.

  • net/http/httputil: ReverseProxy should not forward unparseable query parameters

    Requests forwarded by ReverseProxy included the raw query parameters from the inbound request, including unparseable parameters rejected by net/http. This could permit query parameter smuggling when a Go proxy forwards a parameter with an unparseable value.

    ReverseProxy will now sanitize the query parameters in the forwarded query when the outbound request's Form field is set after the ReverseProxy.Director function returns, indicating that the proxy has parsed the query parameters. Proxies which do not parse query parameters continue to forward the original query parameters unchanged.

    Thanks to Gal Goldstein (Security Researcher, Oxeye) and Daniel Abeles (Head of Research, Oxeye) for reporting this issue.

    This is CVE-2022-2880 and Go issue https://go.dev/issue/54663.

  • regexp/syntax: limit memory used by parsing regexps

    The parsed regexp representation is linear in the size of the input, but in some cases the constant factor can be as high as 40,000, making relatively small regexps consume much larger amounts of memory.

    Each regexp being parsed is now limited to a 256 MB memory footprint. Regular expressions whose representation would use more space than that are now rejected. Normal use of regular expressions is unaffected.

    Thanks to Adam Korczynski (ADA Logics) and OSS-Fuzz for reporting this issue.

    This is CVE-2022-41715 and Go issue https://go.dev/issue/55949.

View the release notes for more information: https://go.dev/doc/devel/release#go1.18.7

@thaJeztah thaJeztah closed this Oct 4, 2022
@thaJeztah thaJeztah reopened this Oct 4, 2022
@thaJeztah thaJeztah force-pushed the 1.6_bump_go_1.18.7 branch 3 times, most recently from aab2c88 to 96864cc Compare October 4, 2022 20:50
@thaJeztah
Copy link
Copy Markdown
Member Author

I have a feeling that the gofmt linter is applying go1.19 rules, despite golangci-lint running with go1.18. When I run gofmt in a 1.18 environment, I get no changes, but with 1.19, I do, and formatting with 1.19 makes the linter happy 🤔

thaJeztah and others added 4 commits October 4, 2022 23:59
it looks like golangci-lint's gofmt check uses go1.19 rules, despite
being run with go1.18.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
(cherry picked from commit 3a3f43f)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
for compatibility with Go 1.18

Signed-off-by: Sebastiaan van Stijn <[email protected]>
CVE-2022-41715

From the mailing list:

We have just released Go versions 1.19.2 and 1.18.7, minor point releases.

These minor releases include 3 security fixes following the security policy:

- archive/tar: unbounded memory consumption when reading headers

  Reader.Read did not set a limit on the maximum size of file headers.
  A maliciously crafted archive could cause Read to allocate unbounded
  amounts of memory, potentially causing resource exhaustion or panics.
  Reader.Read now limits the maximum size of header blocks to 1 MiB.

  Thanks to Adam Korczynski (ADA Logics) and OSS-Fuzz for reporting this issue.

  This is CVE-2022-2879 and Go issue https://go.dev/issue/54853.

- net/http/httputil: ReverseProxy should not forward unparseable query parameters

  Requests forwarded by ReverseProxy included the raw query parameters from the
  inbound request, including unparseable parameters rejected by net/http. This
  could permit query parameter smuggling when a Go proxy forwards a parameter
  with an unparseable value.

  ReverseProxy will now sanitize the query parameters in the forwarded query
  when the outbound request's Form field is set after the ReverseProxy.Director
  function returns, indicating that the proxy has parsed the query parameters.
  Proxies which do not parse query parameters continue to forward the original
  query parameters unchanged.

  Thanks to Gal Goldstein (Security Researcher, Oxeye) and
  Daniel Abeles (Head of Research, Oxeye) for reporting this issue.

  This is CVE-2022-2880 and Go issue https://go.dev/issue/54663.

- regexp/syntax: limit memory used by parsing regexps

  The parsed regexp representation is linear in the size of the input,
  but in some cases the constant factor can be as high as 40,000,
  making relatively small regexps consume much larger amounts of memory.

  Each regexp being parsed is now limited to a 256 MB memory footprint.
  Regular expressions whose representation would use more space than that
  are now rejected. Normal use of regular expressions is unaffected.

  Thanks to Adam Korczynski (ADA Logics) and OSS-Fuzz for reporting this issue.

  This is CVE-2022-41715 and Go issue https://go.dev/issue/55949.

View the release notes for more information: https://go.dev/doc/devel/release#go1.18.7

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@AkihiroSuda AkihiroSuda merged commit 1eb637f into containerd:release/1.6 Oct 5, 2022
@thaJeztah thaJeztah deleted the 1.6_bump_go_1.18.7 branch October 5, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants