Add new ctr option for discarding unpacked layers#7425
Merged
samuelkarp merged 2 commits intocontainerd:mainfrom Oct 10, 2022
Merged
Add new ctr option for discarding unpacked layers#7425samuelkarp merged 2 commits intocontainerd:mainfrom
samuelkarp merged 2 commits intocontainerd:mainfrom
Conversation
|
Hi @Jenkins-J. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add a new ctr cli option, allowing the garbage collector to discard any unpacked layers after importing an image. This new option is incompatible with the no-unpack ctr import option. Signed-off-by: James Jenkins <[email protected]>
Jenkins-J
force-pushed
the
ctr-dev-import
branch
from
cccff4a to
2432b54
Compare
dcantah
reviewed
Sep 29, 2022
Modify the WithDiscardUnpackedLayers function such that it does not require any parameters. Signed-off-by: James Jenkins <[email protected]>
dmcgowan
approved these changes
Sep 29, 2022
samuelkarp
approved these changes
Oct 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new ctr cli option, allowing the garbage collector to discard any unpacked layers after importing an image. This new option is incompatible with the no-unpack ctr import option. This addresses issue #7125.