Configure CDI registry only on start#7419
Merged
fuweid merged 4 commits intocontainerd:mainfrom Oct 22, 2022
Merged
Conversation
|
Hi @bart0sh. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bart0sh
force-pushed
the
PR005-configure-CDI-registry-on-start
branch
2 times, most recently
from
f1c6cca to
3e6a272
Compare
bart0sh
changed the title
bart0sh
force-pushed
the
PR005-configure-CDI-registry-on-start
branch
from
3e6a272 to
15eae63
Compare
Contributor
Author
|
/cc @mikebrow |
Contributor
Author
|
/cc @kzys @MikeZappa87 |
Contributor
Author
|
/cc @AkihiroSuda @fuweid |
klihub
reviewed
Oct 4, 2022
fuweid
reviewed
Oct 5, 2022
As WithCDI is CRI-only API it makes sense to move it out of oci module. This move can also fix possible issues with this API when CRI plugin is disabled. Signed-off-by: Ed Bartosh <[email protected]>
Currently CDI registry is reconfigured on every WithCDI call, which is a relatively heavy operation. This happens because cdi.GetRegistry(cdi.WithSpecDirs(cdiSpecDirs...)) unconditionally reconfigures the registry (clears fs notify watch, sets up new watch, rescans directories). Moving configuration to the criService.initPlatform should result in performing registry configuration only once on the service start. Signed-off-by: Ed Bartosh <[email protected]>
Added logging of found CDI devices. Fixed test failures caused by the change. Signed-off-by: Ed Bartosh <[email protected]>
bart0sh
force-pushed
the
PR005-configure-CDI-registry-on-start
branch
from
15eae63 to
643dc16
Compare
Signed-off-by: Ed Bartosh <[email protected]>
bart0sh
force-pushed
the
PR005-configure-CDI-registry-on-start
branch
from
def093a to
347397c
Compare
Contributor
Author
Contributor
Author
AkihiroSuda
approved these changes
Oct 21, 2022
fuweid
reviewed
Oct 21, 2022
fuweid
approved these changes
Oct 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently CDI registry is reconfigured on every WithCDI call, which is a relatively heavy operation.
This happens because cdi.GetRegistry(cdi.WithSpecDirs(cdiSpecDirs...)) unconditionally reconfigures the registry (clears fs notify watch, sets up new watch, rescans directories).
Moving configuration to the criService.initPlatform should result in performing registry configuration only once on the service start.