cri-integration: propagate ENABLE_CRI_SANDBOXES#7413
Merged
mxpv merged 2 commits intocontainerd:mainfrom Sep 21, 2022
Merged
Conversation
sudo(8) strips environment variables by default. Explicitly set ENABLE_CRI_SANDBOXES so we can ensure we test the sbserver CRI implementation. Signed-off-by: Samuel Karp <[email protected]>
Port of b7b1200 to sbserver Signed-off-by: Samuel Karp <[email protected]>
samuelkarp
force-pushed
the
cri-integration-sandboxed
branch
from
5335e56 to
c8010b9
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make cri-integrationwasn't properly propagatingENABLE_CRI_SANDBOXES, meaning we were not fully testing thesbserverCRI implementation. This PR fixes that and also ports over some changes from #6517 that hadn't made it intosbserver(and weren't caught because CI wasn't running the tests against that implementation).(cc @ruiwen-zhao)