Skip to content

reference CDI configuration details#7408

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
bart0sh:PR004-refer-CDI-configuration-doc
Sep 22, 2022
Merged

reference CDI configuration details#7408
dmcgowan merged 1 commit intocontainerd:mainfrom
bart0sh:PR004-refer-CDI-configuration-doc

Conversation

@bart0sh
Copy link
Copy Markdown
Contributor

@bart0sh bart0sh commented Sep 20, 2022

Referenced CDI configuration details as requested in this review comment

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Sep 20, 2022

Hi @bart0sh. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bart0sh bart0sh force-pushed the PR004-refer-CDI-configuration-doc branch from 56dc4d8 to 4bf6938 Compare September 20, 2022 13:04
estesp
estesp approved these changes Sep 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samuelkarp
samuelkarp reviewed Sep 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update https://github.com/containerd/containerd/blob/main/docs/cri/config.md? There's an example config file where this comment would be useful too.

@bart0sh bart0sh force-pushed the PR004-refer-CDI-configuration-doc branch from 4bf6938 to e22a7a3 Compare September 21, 2022 08:32
@bart0sh
Copy link
Copy Markdown
Contributor Author

bart0sh commented Sep 21, 2022

Can you also update https://github.com/containerd/containerd/blob/main/docs/cri/config.md? There's an example config file where this comment would be useful too.

Thank you for the review. I'v updated the config.md as requested.

@samuelkarp samuelkarp added the area/cri Container Runtime Interface (CRI) label Sep 21, 2022
@dmcgowan dmcgowan merged commit 97b8b15 into containerd:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

area/cri Container Runtime Interface (CRI) needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bart0sh @k8s-ci-robot @dmcgowan @samuelkarp @estesp