Skip to content

Refactor CRI fuzzers#7405

Merged
mxpv merged 1 commit intocontainerd:mainfrom
kzys:cri-fuzz
Sep 22, 2022
Merged

Refactor CRI fuzzers#7405
mxpv merged 1 commit intocontainerd:mainfrom
kzys:cri-fuzz

Conversation

@kzys
Copy link
Copy Markdown
Member

@kzys kzys commented Sep 19, 2022

pkg/cri/sbserver/cri_fuzzer.go and pkg/cri/server/cri_fuzzer.go were mostly the same.

This commit merges them together and move the unified fuzzer to contrib/fuzz again to sort out dependencies. pkg/cri/ shouldn't consume cmd/.

@k8s-ci-robot
Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kzys kzys force-pushed the cri-fuzz branch 2 times, most recently from 353f7b8 to 9a8623f Compare September 19, 2022 22:00
@kzys kzys changed the title Separate cmd/ as a Go module Refactor CRI fuzzers Sep 19, 2022
pkg/cri/sbserver/cri_fuzzer.go and pkg/cri/server/cri_fuzzer.go were
mostly the same.

This commit merges them together and move the unified fuzzer to
contrib/fuzz again to sort out dependencies. pkg/cri/ shouldn't consume
cmd/.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@kzys kzys marked this pull request as ready for review September 19, 2022 22:50
@kzys
Copy link
Copy Markdown
Member Author

kzys commented Sep 19, 2022

@AdamKorcz
Copy link
Copy Markdown
Contributor

Hmm, there is a panic, but not from the code I modified.

https://github.com/containerd/containerd/actions/runs/3085986312/jobs/4989883030#step:5:7629

Seems okay now. Might have been just a flaky.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelkarp samuelkarp added the area/cri Container Runtime Interface (CRI) label Sep 21, 2022
@mxpv mxpv merged commit 39f7cd7 into containerd:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cri Container Runtime Interface (CRI)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants