Skip to content

Fix "getCPUInfo for OS freebsd: not implemented" on FreeBSD/arm64#7403

Merged
kzys merged 1 commit intocontainerd:mainfrom
kit-ty-kate:freebsd-arm64
Nov 4, 2022
Merged

Fix "getCPUInfo for OS freebsd: not implemented" on FreeBSD/arm64#7403
kzys merged 1 commit intocontainerd:mainfrom
kit-ty-kate:freebsd-arm64

Conversation

@kit-ty-kate
Copy link
Copy Markdown
Contributor

cc @dfr

I'm not sure how to do better for arm32 but at least it's a step.

See samuelkarp/runj#33 (comment) for an example of the failure.

@k8s-ci-robot
Copy link
Copy Markdown

Hi @kit-ty-kate. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. How about using sysctl? golang/go#47006 (comment)
  2. What is the negative side-effects of detecting ARMv7 as unknown? If it doesn't have any, I'm fine having a stopgap solution for now.

cc @samuelkarp

@samuelkarp
Copy link
Copy Markdown
Member

How about using sysctl? golang/go#47006 (comment)
What is the negative side-effects of detecting ARMv7 as unknown? If it doesn't have any, I'm fine having a stopgap solution for now.

I think using a sysctl is probably fine, but it sounds like @kit-ty-kate isn't in a position to test whether that works across other variants. The change in this PR seems like a strict improvement to me over the prior behavior of unconditionally returning an error. If we're concerned about the "unknown" value, we could (as a stopgap) make that branch continue to return an error.

Comment thread platforms/cpuinfo.go Outdated
@kzys
Copy link
Copy Markdown
Member

kzys commented Oct 19, 2022

The change looks good, but you need to have the DCO (signed-off line).

Can you try git commit --amend -s? Please make sure your email address and name are valid.

@dfr
Copy link
Copy Markdown

dfr commented Nov 3, 2022

The two failing tests look like flakes - could someone re-run them?

@kzys
Copy link
Copy Markdown
Member

kzys commented Nov 3, 2022

@kit-ty-kate Can you rebase this branch to have #7539? This would fix rockylinux/8 build.

@kit-ty-kate
Copy link
Copy Markdown
Contributor Author

@kzys I just did that but that didn't help

@kzys
Copy link
Copy Markdown
Member

kzys commented Nov 4, 2022

At least you don't have the failure on rockylinux/8 anymore. Let me re-run other failed ones.

@kzys
Copy link
Copy Markdown
Member

kzys commented Nov 4, 2022

/ok-to-test

It wouldn't impact Kubernetes though.

@kzys kzys merged commit 88dc30a into containerd:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants