Fix "getCPUInfo for OS freebsd: not implemented" on FreeBSD/arm64#7403
Fix "getCPUInfo for OS freebsd: not implemented" on FreeBSD/arm64#7403kzys merged 1 commit intocontainerd:mainfrom
Conversation
|
Hi @kit-ty-kate. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kzys
left a comment
There was a problem hiding this comment.
- How about using sysctl? golang/go#47006 (comment)
- What is the negative side-effects of detecting ARMv7 as unknown? If it doesn't have any, I'm fine having a stopgap solution for now.
cc @samuelkarp
I think using a sysctl is probably fine, but it sounds like @kit-ty-kate isn't in a position to test whether that works across other variants. The change in this PR seems like a strict improvement to me over the prior behavior of unconditionally returning an error. If we're concerned about the "unknown" value, we could (as a stopgap) make that branch continue to return an error. |
fca9c34 to
a6260a2
Compare
|
The change looks good, but you need to have the DCO (signed-off line). Can you try |
a6260a2 to
2f49da9
Compare
|
The two failing tests look like flakes - could someone re-run them? |
|
@kit-ty-kate Can you rebase this branch to have #7539? This would fix rockylinux/8 build. |
Signed-off-by: Kate <[email protected]>
2f49da9 to
f32595a
Compare
|
@kzys I just did that but that didn't help |
|
At least you don't have the failure on rockylinux/8 anymore. Let me re-run other failed ones. |
|
/ok-to-test It wouldn't impact Kubernetes though. |
cc @dfr
I'm not sure how to do better for arm32 but at least it's a step.
See samuelkarp/runj#33 (comment) for an example of the failure.