Skip to content

Replace github.com/emicklei/go-restful package, versions <2.16.0#7395

Merged
kzys merged 1 commit intocontainerd:mainfrom
kaovilai:SNYK-GOLANG-GITHUBCOMEMICKLEIGORESTFUL-2435653
Sep 15, 2022
Merged

Replace github.com/emicklei/go-restful package, versions <2.16.0#7395
kzys merged 1 commit intocontainerd:mainfrom
kaovilai:SNYK-GOLANG-GITHUBCOMEMICKLEIGORESTFUL-2435653

Conversation

@kaovilai
Copy link
Copy Markdown
Contributor

@kaovilai kaovilai commented Sep 14, 2022

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Sep 14, 2022

Hi @kaovilai. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kaovilai kaovilai force-pushed the SNYK-GOLANG-GITHUBCOMEMICKLEIGORESTFUL-2435653 branch 3 times, most recently from fe084f1 to 3dd25e1 Compare September 14, 2022 16:19
@kzys
Copy link
Copy Markdown
Member

kzys commented Sep 14, 2022 •
edited
Loading

Thanks! Please update go.mod/go.sum in https://github.com/containerd/containerd/tree/main/integration/client as well. go mod tidy there should be all you need.

@kaovilai
Copy link
Copy Markdown
Contributor Author

kaovilai commented Sep 14, 2022

@kzys this PR is tidied.

~/git/containerd SNYK-GOLANG-GITHUBCOMEMICKLEIGORESTFUL-2435653
❯ go mod tidy                              

~/git/containerd SNYK-GOLANG-GITHUBCOMEMICKLEIGORESTFUL-2435653
❯ git status 
On branch SNYK-GOLANG-GITHUBCOMEMICKLEIGORESTFUL-2435653
Your branch is up to date with 'origin/SNYK-GOLANG-GITHUBCOMEMICKLEIGORESTFUL-2435653'.

nothing to commit, working tree clean

~/git/containerd SNYK-GOLANG-GITHUBCOMEMICKLEIGORESTFUL-2435653
❯ git reflog -s
3dd25e11b (HEAD -> SNYK-GOLANG-GITHUBCOMEMICKLEIGORESTFUL-2435653, origin/SNYK-GOLANG-GITHUBCOMEMICKLEIGORESTFUL-2435653) HEAD@{0}: commit (amend): github.com/emicklei/go-restful CWE-285: Improper Authorization
fe084f1b4 HEAD@{1}: commit (amend): github.com/emicklei/go-restful CWE-285: Improper Authorization
834eae024 HEAD@{2}: commit (amend): github.com/emicklei/go-restful CWE-285: Improper Authorization
d2be03214 (main) HEAD@{3}: checkout: moving from main to SNYK-GOLANG-GITHUBCOMEMICKLEIGORESTFUL-2435653
d2be03214 (main) HEAD@{4}: commit: github.com/emicklei/go-restful CWE-285: Improper Authorization
f4095a687 (upstream/main, upstream/HEAD, origin/main) HEAD@{5}: clone: from https://github.com/containerd/containerd/

~/git/containerd SNYK-GOLANG-GITHUBCOMEMICKLEIGORESTFUL-2435653
❯ go version   
go version go1.18.3 darwin/arm64

@kaovilai kaovilai force-pushed the SNYK-GOLANG-GITHUBCOMEMICKLEIGORESTFUL-2435653 branch from 3dd25e1 to 58ea5d7 Compare September 14, 2022 18:38
@kaovilai kaovilai force-pushed the SNYK-GOLANG-GITHUBCOMEMICKLEIGORESTFUL-2435653 branch from 58ea5d7 to 524d3ac Compare September 14, 2022 18:38
@kaovilai
Copy link
Copy Markdown
Contributor Author

kaovilai commented Sep 14, 2022

nvm.. had to cd into said dir to tidy.

estesp
estesp approved these changes Sep 14, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kzys
kzys approved these changes Sep 15, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Let me re-run the failed test.

@kzys
Copy link
Copy Markdown
Member

kzys commented Sep 15, 2022

/ok-to-test

@kzys kzys merged commit 290ef2b into containerd:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kaovilai @k8s-ci-robot @kzys @cpuguy83 @estesp