Skip to content

remotes/docker/config: Skipping TLS verification for localhost #7393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
estesp merged 1 commit into from
Sep 19, 2022
Merged

remotes/docker/config: Skipping TLS verification for localhost #7393

estesp merged 1 commit into from
Sep 19, 2022

Conversation

@Iceber
Copy link
Member

@Iceber Iceber commented Sep 13, 2022

issue: #7392

After configuring config_path for the cri plugin, it doesn't handle the case where the host is local.
We also need to skipping TLS verification for localhost.

@k8s-ci-robot
Copy link

k8s-ci-robot commented Sep 13, 2022

Hi @Iceber. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estesp
Copy link
Member

estesp commented Sep 13, 2022

/ok-to-test

estesp
estesp approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit a1e4a94 into containerd:main Sep 19, 2022
@estesp estesp mentioned this pull request Sep 19, 2022
Closed
@estesp
Copy link
Member

estesp commented Sep 19, 2022

I believe this is a bug fix and should be cherry-picked to release/1.6

@Iceber Iceber mentioned this pull request Sep 27, 2022
Merged
mxpv added a commit to mxpv/containerd that referenced this pull request Jan 17, 2023
@mxpv
Backport containerd#7393 to sbserver
f9f8455 
Signed-off-by: Maksym Pavlenko <[email protected]>
@mxpv mxpv mentioned this pull request Jan 17, 2023
Merged
@mxpv mxpv added cherry-picked/sbserver Changes are backported to sbserver and removed cherry-pick/sbserver labels Jan 19, 2023
@thaJeztah thaJeztah added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch and removed cherry-pick/1.6.x labels Jan 24, 2023
@Poulpatine Poulpatine mentioned this pull request Mar 29, 2023
Closed
@JohnJAS
Copy link

JohnJAS commented May 11, 2023 •
edited
Loading

@Iceber This fix caused another problem. The ctr command now uses http to pull images from a https localhost registry. However, the ctr command only has the--plain-httpoption. So it can never connect to the https registry anymore. I have to revert this change and rebuilt the ctr binary.
Add the discussion here. #8182

@Iceber
Copy link
Member Author

Iceber commented May 11, 2023

@JohnJAS Thank you for pinging me here, otherwise I wouldn't have known about your question.

I will reply as soon as possible.

jsturtevant pushed a commit to jsturtevant/containerd that referenced this pull request Sep 21, 2023
@mxpv @jsturtevant
Backport containerd#7393 to sbserver
c519148 
Signed-off-by: Maksym Pavlenko <[email protected]>
kiashok pushed a commit to kiashok/containerd that referenced this pull request Oct 23, 2024
@mxpv
Backport containerd#7393 to sbserver
01ff753 
Signed-off-by: Maksym Pavlenko <[email protected]>
kiashok added a commit to kiashok/containerd that referenced this pull request Oct 23, 2024
@kiashok
Merged PR 7482211: Update containerd fork-external/main with upstream…
d66a29a 
… main

Updates ADO containerd fork-external/main with upstream containerd main @commit hash: f9f8455
containerd@f9f8455

Additional changes in the PR:
- update linux container image version
- remove copying LICENSE file in shared-build-stages.yml
- additions to .gdnsuppress

Related work items: containerd#5674, containerd#7393, containerd#7661, containerd#7685, containerd#7810, containerd#7850, containerd#7861, containerd#7879, containerd#7880, containerd#7881, containerd#7882, containerd#7883, containerd#7886, containerd#7887, containerd#7888, containerd#7891, containerd#7892, containerd#7893, containerd#7894, containerd#7903, containerd#7904, containerd#7905, containerd#7906, containerd#7907, containerd#7908, containerd#7911, containerd#7913, containerd#7914, containerd#7917, containerd#7925, containerd#7927, containerd#7928, containerd#7929, containerd#7932, containerd#7935, containerd#7943, containerd#7946, containerd#7948, containerd#7957, containerd#7958, containerd#7960, containerd#7963, containerd#7969, containerd#7970, containerd#7973
kiashok added a commit to kiashok/containerd that referenced this pull request Oct 23, 2024
@kiashok
Merged PR 7534707: Update fork-external/main with upstream containerd…
f02f374 
…/main

Update fork-external/main with upstream containerd/containerd/main at commit hash 3d32da8

Related work items: containerd#5674, containerd#7129, containerd#7393, containerd#7661, containerd#7685, containerd#7810, containerd#7850, containerd#7861, containerd#7882, containerd#7883, containerd#7886, containerd#7891, containerd#7892, containerd#7893, containerd#7903, containerd#7904, containerd#7905, containerd#7906, containerd#7907, containerd#7908, containerd#7911, containerd#7913, containerd#7914, containerd#7917, containerd#7925, containerd#7927, containerd#7928, containerd#7929, containerd#7932, containerd#7935, containerd#7943, containerd#7946, containerd#7948, containerd#7957, containerd#7958, containerd#7959, containerd#7960, containerd#7963, containerd#7968, containerd#7969, containerd#7970, containerd#7973, containerd#7985, containerd#7987, containerd#7994, containerd#8005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@estesp estesp estesp approved these changes

+1 more reviewer

@liangyuanpeng liangyuanpeng liangyuanpeng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherry-picked/sbserver Changes are backported to sbserver cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Iceber @k8s-ci-robot @estesp @JohnJAS @kzys @liangyuanpeng @mxpv @thaJeztah